[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23745 [Applications/Tor Browser]: Tab crashes when using Tor Browser to access Google Drive

#23745: Tab crashes when using Tor Browser to access Google Drive
-------------------------------------------------+-------------------------
 Reporter:  angelotheram2                        |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-crash, tbb-7.0-issues, tbb-      |  Actual Points:
  regression, tbb-e10s, TorBrowserTeam201710     |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:10 gk]:
 > Another thought I had: it might be a good idea to take the old Tor
 Browser version Mike used back then for testing where he realized that
 IndexedDB related data is not getting deleted on `New Identity`. Just to
 be sure we are testing the same thing and it is indeed fixed now but not
 in the old Tor Browser.

 Good idea. I tested the indexedDB demo at
 https://codepen.io/caraya/pen/xVrXrG
 with "browser.privatebrowsing.autostart" set to false
 using our build at
 https://archive.torproject.org/tor-package-archive/torbrowser/5.0a3/tor-
 browser-linux64-5.0a3_en-US.tar.xz
 which is the same TBB version that was available when Mike posted
 ticket:16528#comment:11.

 I confirmed that New Identity does not clear the indexedDB database in
 that version.

 I also re-ran the experiment in comment:8 and confirmed that New Identity
 clears indexedDB in the latest Tor Browser.

 So here are two patches for review: https://github.com/arthuredelstein
 /tor-browser/commits/23745

 Although I could see evidence of FPI in comment:8, I haven't directly
 observed it. I will write code to test that tomorrow. I'm pretty confident
 FPI is happening, though, given the filenames I observed and also by
 confirmation from Mozilla folks, so if there isn't time to wait for that
 test, I would suggest trying it in the alpha anyway.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23745#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs