[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23713 [Metrics/Onionoo]: Add as_name parameter
#23713: Add as_name parameter
-----------------------------+--------------------------
Reporter: cypherpunks | Owner: karsten
Type: enhancement | Status: accepted
Priority: Medium | Milestone:
Component: Metrics/Onionoo | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+--------------------------
Changes (by karsten):
* status: new => accepted
* owner: metrics-team => karsten
Comment:
Sounds useful to me. We should probably implement #21366 first to fully
support AS names containing spaces. But other than that I don't see any
major problems.
For the sake of consistency between field names and parameter names we
might consider renaming the "as_number" ''field'' to just "as". That's
also more consistent with "country" for the country code and
"country_name" for the country name. This change would require a major
version bump, but in this case we could easily include both fields for a
few months until clients are updated. So, adding an "as" field would be
the minor protocol change and removing the "as_number" field would be the
major protocol change. Or maybe the latter would also be a minor change,
because the field is optional. Anyway, something to consider and somewhat
related to this feature request.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23713#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs