[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23981 [Metrics/CollecTor]: Fix NPE and include "bridge-distribution-request" lines in sanitized bridge descriptors
#23981: Fix NPE and include "bridge-distribution-request" lines in sanitized bridge
descriptors
-------------------------------+------------------------------
Reporter: karsten | Owner: iwakeh
Type: defect | Status: needs_review
Priority: High | Milestone:
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+------------------------------
Changes (by karsten):
* status: accepted => needs_review
Comment:
Please review the fix in [https://gitweb.torproject.org/karsten/metrics-
db.git/log/?h=task-23981 my task-23981 branch]. It still lacks a change
log entry, and with more time I'd have done another review run myself, so
handle with care.
Note that I tried to keep the patch minimal in order to get it fixed ASAP.
While working on this patch I considered taking a different approach where
we'd include placeholders for parts that we cannot sanitize yet and fill
them in after finishing to read the original descriptor. This could be a
`List<StringBuilder>` to retain order of original lines and where we'd
keep references to some `StringBuilder`s that we need to sanitize after
reading. Still something to think about. Let's do that after fixing this
ugly bug.
Oh, and we still need to make a final decision what to do with those new
lines. Okay to keep them unchanged?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23981#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs