[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23502 [Core Tor/Tor]: prop224: Don't make IPv4 mandatory because one day we'll have IPv6 only relays
#23502: prop224: Don't make IPv4 mandatory because one day we'll have IPv6 only
relays
----------------------------------------+----------------------------------
Reporter: dgoulet | Owner: dgoulet
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: prop224, tor-relay, tor-hs | Actual Points:
Parent ID: #23493 | Points:
Reviewer: asn | Sponsor:
----------------------------------------+----------------------------------
Changes (by nickm):
* status: merge_ready => needs_revision
Comment:
Small request on the commit: it looks like this commit changes the order
of link specifiers that we generate in `service_intro_point_new()`, which
introduces an unnecessary difference between versions. Can we return to
the old order?
Also, you say above that the ticket "has a fixup commit". But I don't see
it; I only see 1c52d39989fa5ccd8c2c895cdc4eb0c704e0bda3 and
65cd35ce73adc09fece995636ee2622ac77ad827
Otherwise this looks okay to me.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23502#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs