[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23712 [Core Tor/Tor]: sched: DESTROY cell on a circuit bypasses the scheduler

#23712: sched: DESTROY cell on a circuit bypasses the scheduler
----------------------------------------+----------------------------------
 Reporter:  dgoulet                     |          Owner:  dgoulet
     Type:  defect                      |         Status:  merge_ready
 Priority:  Medium                      |      Milestone:  Tor:
                                        |  0.3.3.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  tor-sched, review-group-24  |  Actual Points:
Parent ID:                              |         Points:
 Reviewer:                              |        Sponsor:  SponsorV
----------------------------------------+----------------------------------
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 I'm okay with this change, but first: has this been tested enough to make
 sure that these properties hold?

    1) In the case where the channel has no currently queued cells, the
 DESTROY cell should get sent soon, and not wait for some other activity to
 trigger the scheduler.
    2) DESTROY cells should really get sent.

 It looks to me like they should, given the code, but it would be good to
 be sure, since these are the kind of issues where if we got them wrong, we
 might not notice for a while.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23712#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs