[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27320 [Applications/Tor Browser]: Build certutil for Windows
#27320: Build certutil for Windows
--------------------------------------+--------------------------------
Reporter: JeremyRand | Owner: tbb-team
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+--------------------------------
Changes (by gk):
* keywords: tbb-rbm, TorBrowserTeam201810R => tbb-rbm
* status: needs_review => needs_revision
Comment:
Replying to [comment:11 JeremyRand]:
> > It might take a while for someone from us to look at it, though, as we
are currently busy dealing with Tor Browser 8 issues.
>
> No worries. I glanced at the issue tracker, and indeed, sounds like you
guys are dealing with a bunch of things far more important than my patch.
Feel free to prioritize accordingly. :)
>
> In the meantime, I pushed a few more commits to
https://notabug.org/JeremyRand/tor-browser-build/src/certutil , which add
macOS output, nssckbi, and modutil/pk12/shlibsign. Current Git commit
hash is 3f99b9190e056ae5f46d97d51b77ab428ffefc41 .
Sorry for the delay. I think the commits look mostly good. I am not
convinced yet that we need to include `libssp-0.dll` yet. If you check the
included binaries in the mar-tools directory there is non that has
`stack_chk`* in it. (see: comment:11:ticket:15138) Compare that to the
output you get from checking the binaries in tor-browser_en-
US\Browser\TorBrowser\Tor. (I think that's due to us using
`LDFLAGS="$LDFLAGS -static"` for our mingw-w64 builds for the browser
part)
Could you rebase your branch on `master`, too?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27320#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs