[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #28009 [Core Tor/Tor]: shellcheck: cov-diff issues

#28009: shellcheck: cov-diff issues
------------------------------+--------------------
     Reporter:  rl1987        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------
 Shellcheck (​​​https://github.com/koalaman/shellcheck) finds the following
 issues:

 {{{

 In cov-diff line 10:
 for B in $DIRB/*; do
          ^-- SC2231: Quote expansions in this for loop glob to prevent
 wordsplitting, e.g. "$dir"/*.txt .


 In cov-diff line 11:
   A=$DIRA/`basename $B`
           ^-- SC2006: Use $(..) instead of legacy `..`.
                     ^-- SC2086: Double quote to prevent globbing and word
 splitting.


 In cov-diff line 12:
   if [ -f $A ]; then
           ^-- SC2086: Double quote to prevent globbing and word splitting.

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28009>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs