[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23925 [Applications/Tor Browser]: 2018 Tor Browser donation banner
#23925: 2018 Tor Browser donation banner
-------------------------------------------------+-------------------------
Reporter: arthuredelstein | Owner: tbb-
| team
Type: task | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-fundraising, ux-team, | Actual Points:
TorBrowserTeam201810 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):
* status: needs_revision => needs_review
Comment:
Replying to [comment:9 gk]:
> Replying to [comment:4 gk]:
> > 3) I think the user should at least be able to be aware about what is
happening *before* they click on the button that leads them to the
donation page. Maybe showing the URL they are about to go to would be a
good step in that direction.
>
> We did so at least last year and I think we should show the URL, which a
user is about to go to, again if they are hovering over the button.
Good idea and thanks for the review. I should note that I am not including
the locale in the URL in this banner, because it occurred to me that we
are in general promising users not to reveal their locale if they choose
to spoof `navigator.language`. However, the donate page will still show
the right locale if the user is not spoofing. So the only thing our URL is
revealing is which text the user clicked on, which I think doesn't reveal
much about individual users.
Here's my revised patch:
https://github.com/arthuredelstein/torbutton/commit/23925+1
This version shows the URL in the status bar when the user hovers over the
button (because the button is now an `<a>` element). In this revision I
have also added cyan highlighting over part of Line 2 as designed by
Antonela in https://marvelapp.com/a131e34/screen/48876402.
Here are a couple of example screenshots:
* https://arthuredelstein.net/banner_v3_libertad.png
* https://arthuredelstein.net/banner_v3_farsi.png
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23925#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs