[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28096 [Core Tor/Tor]: Windows 8.1 and 10 relays claim to be Windows 8
#28096: Windows 8.1 and 10 relays claim to be Windows 8
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.6.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.2.2.34
Severity: Normal | Resolution:
Keywords: windows, fast-fix, 029-backport, | Actual Points: 0.2
033-backport, 034-backport, 035-backport |
Parent ID: | Points: 0.2
Reviewer: asn | Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):
* status: needs_review => needs_revision
Comment:
Patch looks good in principle:
Two things:
a) Do you think we can add a unittest for this `get_uname()` function to
test that the new table entries work and will work correctly?
b) Should we change `Windows 8` to `Windows 8 or later` even tho the info
remains the same? Could there be scripts that break on this?
Marking as needs_revision to get some answers.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28096#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs