[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26368 [Core Tor/Tor]: Consider circuit isolation when closing redundant intro points
#26368: Consider circuit isolation when closing redundant intro points
-------------------------------------------------+-------------------------
Reporter: sysrqb | Owner: neel
Type: defect | Status:
| needs_revision
Priority: High | Milestone: Tor:
| 0.3.6.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, tor-client, 035-roadmap- | Actual Points:
proposed, tbb-needs |
Parent ID: | Points:
Reviewer: dgoulet | Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):
* status: needs_review => needs_revision
Comment:
I discussed this with Nick a bit on IRC and here is the reality with
isolation flags. Here is the gist quoting him:
{{{
<+nickm> so, the isolation flags aren't really meaningful on their own...
<+nickm> An isolation flag ISO_FOO on a stream means "this stream must be
isolated from all other streams with a different FOO"
<+nickm> but if stream 1 has ISO_FOO set, and stream 2 has a different
value for "foo", then they can't share a circuit
<+nickm> If stream 1 has ISO_DESTPORT set, it can still share a circuit
with stream 2 if stream 2 has the same value for its destport
}}}
That being said, Nick also pointed out to me this wonderful function:
`connection_edge_compatible_with_circuit()` that should tell you if you
can use the circuit or not for the given connection (in this case the
SOCKS conn).
Sorry for all this confusion... it wasn't clear to me either how to
proceed.
About the unit tests, you can do your own MOCKed function instead of using
the one already in the unit test. Just add a new one with a meaningful
name and do whatever you want in there.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26368#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs