[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28114 [Metrics/Library]: Improve getter names for boolean fields in metrics-lib

#28114: Improve getter names for boolean fields in metrics-lib
-----------------------------+------------------------------
 Reporter:  efgyirfe784      |          Owner:  metrics-team
     Type:  enhancement      |         Status:  new
 Priority:  Medium           |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by irl):

 I do prefer the isXY() format for boolean getters, but I wonder what to do
 about these in the ServerDescriptor interface. Some suggestions:

 {{{
 public boolean getUsesEnhancedDnsLogic() -> isUsingEnhancedDnsLogic()
 public boolean getCachesExtraInfo() -> isExtraInfoCache()
 public boolean getAllowSingleHopExits() -> isSingleHopExit()
 public boolean getTunnelledDirServer() -> isTunnelledDirServer()
 }}}

 A side note: there is a typo in the JavaDoc for getTunnelledDirServer()
 that could be fixed at the same time.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28114#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs