[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28100 [Core Tor/Tor]: Tor shouldn't set Content-Type: application/octet-stream when compressing results

#28100: Tor shouldn't set Content-Type: application/octet-stream when compressing
results
-------------------------------------------------+-------------------------
 Reporter:  Hello71                              |          Owner:  Hello71
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  033-backport-maybe-not, 034          |  Actual Points:
  -backport-maybe-not, 035-backport-maybe-not    |
Parent ID:                                       |         Points:
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  033-backport-maybe, 034-backport-maybe, 035-backport-maybe =>
     033-backport-maybe-not, 034-backport-maybe-not, 035-backport-maybe-not
 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.6.x-final


Comment:

 This change passes chutney.

 Stem does check content-type in its unit tests:
 https://github.com/torproject/stem/blob/1c030e32539d1e10facbb2684c65103bca45b966/test/unit/descriptor/remote.py#L284
 Since we run test-stem in CI as of #27913, I re-ran CI on this branch. It
 passes:
 https://travis-ci.org/torproject/tor/jobs/448224335

 I also check if this branch changed browser behaviour. I fetched
 127.0.0.1/tor/server/authority[.z] with Safari:
 * authority on 0.3.6.0-alpha-dev shows the text of the descriptor in the
 browser
 * authority.z on 0.3.6.0-alpha-dev downloads it as a file
 * authority on this branch shows the text of the descriptor in the browser
 * authority.z on this branch shows the text of the descriptor in the
 browser
   * was transparent decompression the intended behaviour?

 This change is a tor version distinguisher for directory authorities and
 directory mirrors (including bridges). But it isn't a version
 distinguisher for onion services, because they do not use compression. So
 I think it's ok to merge and backport.

 We should test this branch in an alpha before backport. It might not be
 necessary to backport it: I don't think we need a backport so that people
 can use their browser windows to view particular tor URLs.

 Once the comments from the review have been fixed, please put this ticket
 in merge_ready.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28100#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs