[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

#25013: Move TorButton code to the tor browser repository
-----------------------------------------------+---------------------------
 Reporter:  igt0                               |          Owner:  tbb-team
     Type:  defect                             |         Status:
                                               |  needs_information
 Priority:  High                               |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201810R  |  Actual Points:
Parent ID:  #10760                             |         Points:
 Reviewer:  gk, sysrqb, mcs,                   |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by gk):

 Replying to [comment:44 igt0]:
 > Replying to [comment:43 gk]:
 > > `toolkit/` is fine. Some questions that came to mind while looking
 over the changes
 > >
 > > 1) Do we really need the bug component part of the `moz.build` file?
 That is meant for Mozilla's Bugzilla I think which we won't use anyway.
 >
 > Awesome
 >
 > >
 > > 2) Why is it not enough to just have something like
 > >
 > > `% locale torbutton @AB_CD@ %locale/@AB_CD@/`
 > >
 > > but do
 > > {{{
 > > #if AB_CD == en_US
 > >  locale/@AB_CD@/            (src/chrome/locale/en/*)
 > > #else
 > >  locale/@AB_CD@/                (src/chrome/locale/@AB_CD@/*)
 > > #endif
 > > }}}
 > > and treat en-US like a special case?
 >
 > The mozilla locale handler doesn't have an "en" language. American
 english is defined as en_US. So we could rename the src/chrome/locale/en
 folder to en_US or do this workaround. (Other extensions do the same
 thing)

 Are we sure "en" is the only locale in Torbutton as we ship it that is
 affected? That said, I think we should rather fix that issue than work
 around it (especially as we ship an *en-US* bundle and not an *en* one).
 I'll ping emmapeel for the translations related issue but hope it is not
 that hard to move to en-US. Otherwise we could add a symlink for now?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25013#comment:45>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs