[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based Tor Browser bundles are not built reproducibly with Stylo enabled using rustc > 1.25.0

#26475: ESR60-based Tor Browser bundles are not built reproducibly with Stylo
enabled using rustc > 1.25.0
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  Immediate                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201810R,      |  Actual Points:
  GeorgKoppen201810, tbb-backport                |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:57 alexcrichton]:
 > The first commit you mentioned - https://reviews.llvm.org/D33320 - looks
 like it's just some minor renamings?

 Oops, right. That's the last *good* commit. The problem is r304594 (which
 is enabling r301649)

 > The second though - https://reviews.llvm.org/D32653 - definitely looks
 more suspicious. Since the second commit is turning a flag on by default,
 could you take a "good LLVM" just before that commit, turning the flag on,
 and seeing if it has the same reproducibility issue?

 I can do that with r305493 (i.e. the last good commit) but given that
 r305494 is just flipping that feature on by default (and removing unused
 code) I doubt this will give us new insights. Let me know, though, if you
 think otherwise.

 > Otherwise, do you have a standalone LLVM test case you were testing
 with? Or was it largely always through rustc? I don't mind helping out to
 file a bug in LLVM!

 I don't have a standalone LLVM testcase, alas. Not sure how I would write
 a proper one for this usecase. :( I bisected through rustc adapting your
 test script in https://github.com/rust-
 lang/rust/issues/52044#issuecomment-402349038.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26475#comment:58>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs