[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31652 [Core Tor/Tor]: hs-v3: Service circuit retry limit should not close a valid circuit
#31652: hs-v3: Service circuit retry limit should not close a valid circuit
-------------------------------------------------+-------------------------
Reporter: dgoulet | Owner: neel
Type: defect | Status:
| merge_ready
Priority: Medium | Milestone: Tor:
| 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, tor-circuit, 042-should, | Actual Points:
dgoulet-merge |
Parent ID: #30200 | Points: 0.1
Reviewer: asn | Sponsor:
| Sponsor27-must
-------------------------------------------------+-------------------------
Changes (by asn):
* status: needs_review => merge_ready
* keywords: tor-hs, tor-circuit, 042-should => tor-hs, tor-circuit,
042-should, dgoulet-merge
Comment:
I think that looks reasonable. Thanks!
That said, if you have a unittest that does not fail after changing the
behavior of the function, your unittest is not testing the function well
enough. That's what I tried to say at comment:18.
Anyhow, I think that's OK for now tho.
I will mark this as merge_ready, and put David as the merger so that he
takes a second look as well.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31652#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs