[tor-bugs] #32024 [Applications/Tor Browser]: In tor-android-services, document where the code we imported comes from

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#32024: In tor-android-services, document where the code we imported comes from
------------------------------------------+----------------------
     Reporter:  boklm                     |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+----------------------
 In `tor-android-service`, we have commit
 36f9873ff075253f4c1c9e394c91031fd4ba9d4a which is adding a bunch of code:
 https://gitweb.torproject.org/tor-android-
 service.git/commit/?id=36f9873ff075253f4c1c9e394c91031fd4ba9d4a

 However it seems that this code has been taken from various other places,
 but there is no indication of where.

 Ideally we would have kept history of the projects we imported code from
 (for example with `git filter-branch`), or just used sub-modules if we did
 not modify them. But since we didn't do that, I think we should at least
 put somewhere the information about where all the code we include comes
 from.

 For example the `jsocksAndroid` directory seems to be imported from
 https://github.com/guardianproject/jsocks or maybe
 https://github.com/ravn/jsocks, but there is no indication of that, or
 which commit was used. The directory `service/` looks similar to
 https://github.com/guardianproject/orbot/tree/master/orbotservice, but
 there is no indication that it was imported from there, or which commit
 was used.

 I am also wondering why we have both `jsocksAndroid/` and
 `external/jsocks/`.

 We also have a `LICENSE` file containing the Apache License, but it is
 unclear to what it applies since this is neither the license of Orbot of
 jsocks.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32024>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs