[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30504 [Applications/Tor Browser]: Investigate if New Identity works properly after moving to ESR 68
#30504: Investigate if New Identity works properly after moving to ESR 68
-------------------------------------------------+-------------------------
Reporter: acat | Owner: tbb-
| team
Type: task | Status: closed
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution: fixed
Keywords: ff68-esr, tbb-newnym, tbb-9.0-must- | Actual Points: 1.5
alpha, TorBrowserTeam201910R |
Parent ID: | Points: 0.25
Reviewer: | Sponsor:
| Sponsor44-can
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:14 acat]:
> Replying to [comment:12 gk]:
> > Replying to [comment:7 acat]:
[snip]
> > > `TypeError: win.gBrowser is undefined ProcessHangMonitor.jsm:410:18`
> > >
> > > I fixed this one by waiting the new window to be initialized before
closing the last one.
> >
> > Hrm. The drawback of the fix is that the window is now "jumping"
around the screen which might not be desired. That's because the code
seems to not open a new window directly at the place where the current one
still is which was no problem when we closed the older one first.
> >
> > I feel that change is not worth it. That is a usability issue that got
reported in the past actually, see #22536. I think it got better with e10s
improvements as the ticket mentions but we should not make it worse again.
I wonder whether we can patch the code at a different place instead.
>
> I just checked this, and it's happening in the nightlies without this
change, too. For me it opens the new window in a different place than the
old one (if you move it from the original position).
Yes, that's true. But with your code the window would jump around even if
you not move it which is not currently happening (at least not on the
machine I tested).
[snip]
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30504#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs