[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27268 [Applications/Tor Browser]: preferences cleanup
#27268: preferences cleanup
-------------------------------------------------+-------------------------
Reporter: rzb | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ff68-esr, TorBrowserTeam201910R, | Actual Points:
GeorgKoppen201910 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* status: new => needs_review
* keywords: ff60-esr, TorBrowserTeam201809 => ff68-esr,
TorBrowserTeam201910R, GeorgKoppen201910
Comment:
Great work! I'll start with a patch for the first three sections. What
should we set `intl.charset.fallback.override` to in your opinion?
For the prefs not in DXR here is a little tip that has helped me a lot in
the past to track those issues down:
1) Figure out in which file the prefs were used, ideally files which still
exist in your git checkout
2) Do a `git log -p path_to_file`
3) Search in the git log for the prefs. This should give you the commit
where they got removed.
So, https://bugzilla.mozilla.org/show_bug.cgi?id=1254558 is the bug where
they got removed.
`bug_27268` (https://gitweb.torproject.org/user/gk/tor-
browser.git/log/?h=bug_27268) has the first batch of prefs fixups for
review (two commits). There is a Torbutton patch, too, in `bug_27268`
(https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_27268&id=a2eac79bab7c2afa17cd45109a5669cf528215c0):
Note, I removed `security.pki.sha1_enforcement_level` as well even though
the pref is still in action. But we set it to a lower value than Mozilla
ships today which we should not do.
We should figure out as well whether there is a new hotfix mechanism that
still needs to get disabled.
Oh, and I'll adapt the commit message for the preference commit
accordingly next time I rebase the branch.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27268#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs