[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30461 [Applications/Tor Browser]: Update tor-android-service Project to Use Android Toolchain (Firefox 68)

#30461: Update tor-android-service Project to Use Android Toolchain (Firefox 68)
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must-     |  Actual Points:
  alpha, TorBrowserTeam201910                    |
Parent ID:  #30324                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------

Comment (by sisbell):

 I'm agreeing with you, let's move mavenLocal to tor-android-service. I'll
 open the issue on tor-android-service and then remove the patch.

 Replying to [comment:37 gk]:
 > Replying to [comment:36 sisbell]:
 > > I mean that developers who build tor-android-service outside of the
 tor-browser-build don't need the mavenLocal entry. Since we do need it in
 tor-browser-build, adding mavenLocal to tor-android-service is the right
 way to go.
 >
 > You mean in our `tor-browser-build` environment? What about someone who
 wants to build tor-android-service without network access as we do? Why
 should that not be supported directly in tor-android-service? This seems
 to me a valid usecase we should support in general + it would get us rid
 of a patch: having patches directly in `tor-browser-build` is considered a
 bug we should fix, in particular if we own the repository for the
 respective project as we do with tor-android-service.
 >
 > > Replying to [comment:35 gk]:
 > > > Replying to [comment:34 sisbell]:
 > > > > From a tor-android-service, mavenLocal is not directly needed but
 it doesn't hurt to add it directly to the gradle build file for tor build.
 > > >
 > > > What do you mean? If it's not needed then why do we have the
 additional complexity? If it *is* needed then it seems to me supporting
 the Tor build case directly in `tor-android-service` is a plus. Other
 folks might want to build `tor-android-service` the same way as we.
 > > >
 > > > > Replying to [comment:33 gk]:
 > > > > > Thanks this looks better. Why are we shipping the `maven-
 local.patch` and do not add this change to our repo directly? If we add
 `mavenLocal()` as last item then there should not be a functional
 difference to the status quo for projects fetching the dependencies from
 any of the other specified repositories.
 > > > > >
 > > > > > There are still the tickets to file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30461#comment:38>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs