[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68
#30429: Rebase Tor Browser patches for Firefox ESR 68
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: task | Status:
| needs_review
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ff68-esr, tbb-9.0-must-alpha, | Actual Points:
TorBrowserTeam201910R |
Parent ID: | Points: 1
Reviewer: | Sponsor:
| Sponsor44-can
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:80 acat]:
> Replying to [comment:77 gk]:
> > Replying to [comment:75 gk]:
> > > Replying to [comment:74 acat]:
> > > > Fixed in https://github.com/acatarineu/tor-
browser/commits/30429+11. I also changed the last check for the `.onion`
case to `if ((mState & STATE_IS_SECURE) == 0) {`, because I think the
previous `if (mState != STATE_IS_INSECURE) {` may have erased some flags
in case of a https onion.
> > > >
> > > > I changed the comment, but not completely sure if you meant that
or something else :)
> > >
> > > I meant something else but I was wrong. However, the changed comment
*does* add value, so thanks. The patch looks good to me. I'd like to have
another reviewer here (as this is a C++ patch), likely pospeselr.
Menawhile, though, just a small nit to fix up:
> > > {{{
> > > + // router over tor (.onion).
> > > }}}
> > > s/router/routed/
> >
> > Additionally, it seems that somehow your patch is breaking the mobile
experience. With the latest nightly I can see an onion icon and the
session is marked as secure. However, testing your patch with my
`30429_test` (https://gitweb.torproject.org/user/gk/tor-
browser.git/log/?h=30429_test) just gives the regular globe and an
insecure connection setting.
>
> I verified that the fixup in
https://trac.torproject.org/projects/tor/ticket/31010#comment:35 fixes the
mobile issue.
>
> Fixed the typo: https://www.github.com/acatarineu/tor-
browser/commit/30429+12.
Thanks. Looks good to me. I cherry-picked the fix to `tor-
browser-68.1.0esr-9.0-2` (commit
dece7a15a8703596366c54f4420bd7286c66b10f).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30429#comment:82>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs