[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22029 [Core Tor/Tor]: Allow ed25519 keys to be banned in the approved-routers file

#22029: Allow ed25519 keys to be banned in the approved-routers file
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  034-triage-20180328,                 |  Actual Points:
  034-removed-20180328                           |
Parent ID:                                       |         Points:  1
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 I'm pretty sure that this code can't pass as-is; have you tried it out in
 Chutney?

 This change here is the one I'm concerned about:
 {{{
       if (authdir && dirserv_would_reject_router(rs,
                                                  (vote_routerstatus_t
 *)rsp)) {
 }}}

 What makes you sure that is_vote is true?  If it isn't true, then this
 points to a routerstatus_t, not a vote_routerstatus_t.  You can't cast an
 object into a type that it isn't.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22029#comment:78>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs