[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31740 [Applications/Tor Browser]: Review RemoteSettings usages in esr68
#31740: Review RemoteSettings usages in esr68
-------------------------------------------------+-------------------------
Reporter: acat | Owner: tbb-
| team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ff68-esr, tbb-9.0-must-alpha, | Actual Points:
TorBrowserTeam201910 |
Parent ID: | Points: 0.5
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by acat):
Replying to [comment:3 gk]:
> While looking over closed bugs I stumbled over
https://bugzilla.mozilla.org/show_bug.cgi?id=1440022, which might be
relevant here.
The ` "global broadcast"/real time updates API`, should not be enabled as
long as `dom.push.enabled=false`. This is because `PushService` is only
initialized in one place: https://searchfox.org/mozilla-
esr68/rev/4fc15df791ad4d3ceaf1a958af2bfc1252433ca8/dom/push/PushComponents.jsm#22.
And https://searchfox.org/mozilla-
esr68/rev/4fc15df791ad4d3ceaf1a958af2bfc1252433ca8/dom/push/PushBroadcastService.jsm
uses `PushService` but it does not initialize it, just adds some listeners
which will never be used.
`dom.push.enabled` is false in esr68 desktop, but not on mobile AFAIK. We
do have `pref("dom.push.serverURL", "");` which should do the trick, but
we might want to have also `pref("dom.push.enabled", false)` just in
case.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31740#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs