[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32108 [Core Tor/Tor]: tor can overrun its accountingmax if it enters soft hibernation first
#32108: tor can overrun its accountingmax if it enters soft hibernation first
----------------------------+------------------------------------
Reporter: arma | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Core Tor/Tor | Version: Tor: 0.4.0.1-alpha
Severity: Normal | Resolution:
Keywords: network-health | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
----------------------------+------------------------------------
Comment (by arma):
Here is a patch that ought to work, for relay operators getting bitten by
this bug today:
{{{
diff --git a/src/core/mainloop/mainloop.c b/src/core/mainloop/mainloop.c
index 2f8be9961d..6f29a6981a 100644
--- a/src/core/mainloop/mainloop.c
+++ b/src/core/mainloop/mainloop.c
@@ -1388,7 +1388,7 @@ STATIC periodic_event_item_t
mainloop_periodic_events[] = {
/* This is a legacy catch-all callback that runs once per second if
* we are online and active. */
CALLBACK(second_elapsed, NET_PARTICIPANT,
- FL(NEED_NET)|FL(RUN_ON_DISABLE)),
+ FL(RUN_ON_DISABLE)),
/* XXXX Do we have a reason to do this on a callback? Does it do any
good at
* all? For now, if we're dormant, we can let our listeners decay. */
}}}
The eventual patch we merge into the code might be different. Or maybe
this is a great choice for a fix on Tor stable, and we'll do something
smarter for the 0.4.2.x or 0.4.3.x development releases.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32108#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs