[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28763 [Applications/Tor Browser]: Create Tor-Android Project

#28763: Create Tor-Android Project
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm,                 |  Actual Points:
  TorBrowserTeam201901, tbb-parity               |
Parent ID:  #28704                               |         Points:  .5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by eighthave):

 I highly recommend getting rid of all the asset unpacking code from Orbot.
 It is ancient and long unneeded, and indeed problematic.  The
 ''libtor.so'' created by https://github.com/guardianproject/tor-
 android/pull/21 can be directly included in the TBB APKs by putting them
 in the right place on the file system before building.  In tor-android,
 this is done in ''tor-android-binary/src/main/libs'' with ''tor-android-
 binary/src/main/jniLibs'' a symlink to that.

 Then Android will automatically handle all the unpacking in a much more
 secure way.  And it can be either loaded as a shared library without
 setting any paths, e.g. `System.load("tor")` or directly executed as a
 daemon from ''/data/data/org.torproject.torbrowser/lib/libtor.so''.

 If you still need to unpack other assets like ''torrc'', ''geoip'', etc.,
 those should be put into the projects ''assets/'' folder, then there is a
 standard Android method for getting those asset files.  I think Orbot was
 already doing that.

 Then TBB will need nothing from the https://github.com/guardianproject
 /tor-android project anymore.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28763#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs