[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32058 [Core Tor/Tor]: mainloop: make periodic events restartable

#32058: mainloop: make periodic events restartable
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.4.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  042-should, regression?,             |  Actual Points:  0.1
  035-backport, 040-backport, 041-backport,      |
  042-backport, BugSmashFund                     |
Parent ID:                                       |         Points:  0.5
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Looks valid, but I would like to suggest a change for future safety.

 Let's do one of the following:
   * Document, in `periodic_event_disconnect()`, that you must first call
 `periodic_event_disable()`.
   * Make `periodic_event_disconnect()` itself call
 `periodic_event_disable()`, so that we can't forget to do so.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32058#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs