[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31999 [Core Tor/Tor]: Default log file is handled inconsistently



#31999: Default log file is handled inconsistently
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  (none)
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #31241        |         Points:
 Reviewer:  teor          |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Seems fine to me.

 I was wondering how we should test this as I was reading it:
 * can we test the individual functions like we used to test
 options_validate()?
 * should we try to test using our command-line harness?

 It would also be nice to remove unused variables in this ticket:
 {{{
 /* 29211 TODO: Remove this from the API. */
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31999#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs