[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32138 [Applications/Tor Browser]: Clicking the 'new Identity' button in full screen causes the top and bottom of the browser to show white bars that do not go away
#32138: Clicking the 'new Identity' button in full screen causes the top and bottom
of the browser to show white bars that do not go away
--------------------------------------+--------------------------
Reporter: Dbryrtfbcbhgf | Owner: tbb-team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+--------------------------
Comment (by Thorin):
Thanks for the vid
**I'm not mac savvy at all**, so correct me if I'm wrong. But to me it
looks like letterboxing it's working as it's meant to, except I don't
fully understand the mac actions (and the video is too fast for an old guy
like me). OK, I downloaded the vid and am playing it locally at super slow
speed :) I'm typping comments as I go, so it might get a little messy
Some comments
- That doesn't look like FS (full screen) to me (the urlbar is still
visible), that looks like maximizing. However, letterboxing doesn't
distinguish those, and should work the same way.
- When you open TB and the size is perfect (no letterboxing), e.g
1000x1000 and you go FS and then non-FS (i.e you return to the original
state), or go maximized and then restore: well, of course the restored
state will not have letterboxing, because it didn't before you
maximized/FS'ed it.
This is what I see:
- 12 secs: you start tor, etc
- 15 secs: it has loaded chrome but no content (pale grey)
- 16 secs: it has loaded the Tor Browser purple text in the urlbar
- 17 secs: it has loaded the content (the purple page). It is not
letterboxed (therefore it is in multiples of `200`x`100` or see **note**
below), and the size has not changed from first paint
- 18/19 seconds - you have clicked the `green` button, and it transitions
to a maximized state and letterboxing kicks in (it doesn't look vertically
centered)
- 21 seconds - you have clicked the `green` button again, and it restores
and the letterboxing has gone. It is back at the same size. I took screen
shots of each stage and compared them
- **Note**: sometimes, letterboxing does not kick in on the very first
page load: I have not seen this in TB, but I get it every time on my
Firefox. My landing/home page of speed dials loads before letterboxing.
It's a speed/racy thing. I can't tell if this is the case in your vid.
So at this stage, that part is working fine AFAICT
---
The first part of the video
- 0 secs: TB is open, no letterboxing
- 1 secs: you click the green button, it maximizes, gets letterboxed
- 2 secs: you click new ID
- 3 secs: the existing window is closed
- 4 secs: a new window opens, but the size is **full height** (it wasn't
when you started TB at the 12+ sec mark)
- 5 secs: the purple tor page is loaded and letterboxing has kicked it, as
it should **because the inner window height** is not what it should be, it
is trying to use **full height**
When you go new ID, all exiting windows are destroyed and you get a brand
new one which does not respect any previous window sizes or states
It might help is you grabbed the inner window screen measurements at each
step: e.g load
https://ghacksuserjs.github.io/TorZillaPrint/TorZillaPrint.html - but I
don't think that there is a problem with that.
The problem seems to be that, on Mac, the new window height is not
adjusted
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32138#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs