[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32131 [Circumvention/Snowflake]: `SetDeadline not implemented` errors in proxy-go output

#32131: `SetDeadline not implemented` errors in proxy-go output
-------------------------------------+------------------------
 Reporter:  dcf                      |          Owner:  (none)
     Type:  defect                   |         Status:  new
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+------------------------

Comment (by cohosh):

 I agree that we should not be printing out this many warnings.

 There are three ways to fix this:
 - undo these log messages from #31794 to not print out the returned error
 - change the SetDeadline (non)implementation to not return an error
 - implement SetDeadline for webRTCConn

 The last option is perhaps the "most correct" route but also isn't really
 necessary for us since the timeout of the websocket connection will cause
 the copyloop to end. I'm hesitant to add more code that isn't necessary to
 snowflake since there is also a potential for adding bugs.

 I guess I'd prefer just not logging the returned error.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32131#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs