[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus
#31684: Add control port GETINFO support for dumping the local consensus
--------------------------------------------+------------------------------
Reporter: asn | Owner: (none)
Type: enhancement | Status: merge_ready
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: control-port easy extra-review | Actual Points: 0.5
Parent ID: | Points: 1
Reviewer: asn | Sponsor:
--------------------------------------------+------------------------------
Changes (by teor):
* keywords: control-port easy extra-review nickm-merge dgoulet-merge =>
control-port easy extra-review
* type: task => enhancement
* actualpoints: => 0.5
Comment:
I did some fixes:
* standard whitespace
* typos
* standard error handling
* remove unnecessary test code
Here is the branch with all the fixes:
https://github.com/teor2345/tor/commits/ticket31684
There is a description of each fix in my review on PR 1328.
Here is the squashed PR for merging:
* master: https://github.com/torproject/tor/pull/1434
I squashed the whitespace fixes with the rest of the code, to minimise the
diff.
Since these are obvious fixes on already reviewed code, any maintainer can
merge after CI passes.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31684#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs