[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32172 [Core Tor/Tor]: port test suite to Android to run in emulator



#32172: port test suite to Android to run in emulator
---------------------------------+------------------------------------
 Reporter:  eighthave            |          Owner:  (none)
     Type:  task                 |         Status:  needs_revision
 Priority:  Medium               |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  Android, tbb-mobile  |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:  nickm                |        Sponsor:
---------------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Good start!  I've left a couple of comments on the PR.  Additionally this
 needs a changes file.

 WRT the other suggestions:
   * We already disable the python tests when python isn't found.  Is there
 a place where we forget to do that?
   * I'm okay porting our shell scripts to a more generic sh, so long as
 shellcheck still passes.
   * I don't know what to do with the third one; maybe there's a way to
 make autoconf and automake override this?  Is there a `/usr/bin/env sh` we
 could use?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32172#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs