[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32108 [Core Tor/Tor]: tor can overrun its accountingmax if it enters soft hibernation first
#32108: tor can overrun its accountingmax if it enters soft hibernation first
-------------------------------------------------+-------------------------
Reporter: arma | Owner: arma
Type: defect | Status:
| merge_ready
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.4.0.1-alpha
Severity: Normal | Resolution:
Keywords: extra-review consider-backport- | Actual Points:
after-0424 network-health 042-backport |
041-backport 040-backport BugSmashFund |
Parent ID: | Points:
Reviewer: dgoulet, teor | Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):
* status: needs_review => merge_ready
Comment:
I think this is correct change.
However, semantically, we are really in a pit with
`second_elapsed_callback()` that does way too many things and some checks
explicitly look at `net_is_disabled()` which I think is what this fix is
OK.
But a long term proper fix I believe would be to move the accounting into
its own callback. And the expiring of circuit/connections code as well.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32108#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs