[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress
#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: task | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 042-should | Actual Points: 1.5
Parent ID: | Points:
Reviewer: teor | Sponsor: Sponsor31-can
--------------------------+------------------------------------
Changes (by nickm):
* status: needs_revision => needs_review
Comment:
Replying to [comment:14 teor]:
> Seems fine, but there are some typos and minor commit message/content
issues.
I've added a fixup commits for the typos. To solve the commit
message/content issues, I had to squash those and make a new rebased
branch, as `ticket31705_v2`. This still had merge conflicts with master,
so it is merged in a `ticket31705_v2_merged` branch. The PR for that is
https://github.com/torproject/tor/pull/1447 .
> How do you want to make progress on the remaining files?
> Do you want to set up CI, so we preserve cocci compatibility over time?
I don't have a strong opinion here right now: I think it would make more
sense to get some experience using coccinelle more in our regular
development workflow, so we can decide how to prioritize these items.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31705#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs