[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32108 [Core Tor/Tor]: tor can overrun its accountingmax if it enters soft hibernation first

#32108: tor can overrun its accountingmax if it enters soft hibernation first
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  arma
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review consider-backport-      |  Actual Points:
  after-0424 network-health 042-backport         |
  041-backport 040-backport BugSmashFund         |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet, teor                        |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Actually, this might not have the performance regression we're talking
 about.

 The core of the patch here is:
 {{{
   CALLBACK(second_elapsed, NET_PARTICIPANT,
 -           FL(NEED_NET)|FL(RUN_ON_DISABLE)),
 +           FL(RUN_ON_DISABLE)),
 }}}

 So note that this periodic event is still labeled as NET_PARTICIPANT.
 IIRC, when a client enters dormant mode, it lstill loses NET_PARTICIPANT:
 NEED_NET is the only thing affected by hibernation.

 So I think this might be okay?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32108#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs