[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up
#28745: THE Torbutton clean-up
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-torbutton, | Actual Points:
TorBrowserTeam201910R |
Parent ID: #30506 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by acat):
* status: needs_revision => needs_review
* keywords: tbb-torbutton, TorBrowserTeam201910 => tbb-torbutton,
TorBrowserTeam201910R
Comment:
Rebased in https://github.com/acatarineu/torbutton/commits/28745+1 and
https://github.com/acatarineu/tor-browser/commits/28745+1.
I dropped some commits wrt the original `torbutton` changes (`Refactor
code to always use tor-control-port.js`, `Tor controller promises should
fail when there is an error`, `Move torbutton_do_new_identity to separate
module`, `Move some code from torbutton to torCheckService`) as I was not
sure whether they fit in this ticket or they added much value, and the
changes were quite big already. Maybe we can continue on these on later
torbutton refactors?
I think #13198 would be fixed with these changes, and perhaps #19256 too,
although there might be more dead code that I missed.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28745#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs