[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32191 [Core Tor/Tor]: when cross-compiling, lzma and zstd will be detected on build system

#32191: when cross-compiling, lzma and zstd will be detected on build system
----------------------------------+------------------------------------
 Reporter:  eighthave             |          Owner:  (none)
     Type:  defect                |         Status:  needs_revision
 Priority:  Medium                |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor          |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  Android 042-backport  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------------

Comment (by eighthave):

 I think it makes sense to require setting `--prefix` for cross-compiling,
 set `PKG_CONFIG_PATH=$prefix/lib/pkgconfig` whenever cross-compiling.
 I've taken that approach now with tor-android, then each library is
 installed using `make install`:
 https://github.com/guardianproject/tor-
 android/blob/c795392511e5d2a21be14f6096f2c17a6e75f989/external/Makefile#L171

 I'm guessing the MinGW/Windows builds us a cross-compile too, I'm not
 aware of Tor's Windows build setup, so I can't speak to that, though I
 have maintained autotools build systems for Windows before.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32191#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs