[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30920 [Core Tor/Tor]: Detect uint64 overflow in config_parse_units()

#30920: Detect uint64 overflow in config_parse_units()
----------------------------------------+----------------------------------
 Reporter:  nickm                       |          Owner:  (none)
     Type:  defect                      |         Status:  needs_revision
 Priority:  Low                         |      Milestone:  Tor:
                                        |  0.4.3.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Minor                       |     Resolution:
 Keywords:  easy overflow extra-review  |  Actual Points:  0.2
Parent ID:                              |         Points:
 Reviewer:  teor, nickm                 |        Sponsor:
----------------------------------------+----------------------------------

Comment (by guigom):

 Replying to [comment:33 teor]:
 > We need to fail on negative multipliers, because the function returns an
 unsigned integer. I've added a suggestion on the pull request.
 >
 > Once that is applied, I think we can merge, but I'd like nickm to do a
 final review before we merge,

 I've submitted the change and added a negative float test so everything is
 covered.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30920#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs