[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32301 [Applications/Tor Browser]: Update Tor GeoIp Files for Android

#32301: Update Tor GeoIp Files for Android
----------------------------------------------+--------------------------
 Reporter:  sisbell                           |          Owner:  tbb-team
     Type:  defect                            |         Status:  new
 Priority:  Medium                            |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911  |  Actual Points:
Parent ID:                                    |         Points:  .25
 Reviewer:                                    |        Sponsor:
----------------------------------------------+--------------------------
Changes (by sysrqb):

 * keywords:  tbb-mobile, TorBrowserTeam201910 => tbb-mobile,
     TorBrowserTeam201911


Comment:

 As mentioned in #30518, we don't use GeoIP on Android. Tor currently has
 the default:
 {{{
   V(GeoIPFile,                   FILENAME,
     SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip"),
   V(GeoIPv6File,                 FILENAME,
     SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip6"),
 }}}

 and the current tor binary does not override the default SHARE_DATADIR, so
 tor will only find the GeopIPFiles if they are in
 `/usr/local/share/tor/geoip` (which will never be the case on Android).

 We don't need this any time soon because we don't provide a circuit
 display and we don't provide a way for people to exclude nodes by country
 code. Is there another use for geoip besides these?

 I might actually argue this should be handled after #28766 is complete and
 we can use the geoip files from tor in tor-browser-build instead of
 shipping them in both places.

 From #28766, we can move them into `assets/common` in the `tor-android-
 services` build file (instead of `Data/Tor/geoip{,6}` like we do on Linux
 and Windows).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32301#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs