[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29207 [Circumvention/Snowflake]: New design for broker -- proxy protocol for snowflakes
#29207: New design for broker -- proxy protocol for snowflakes
-------------------------------------------------+-------------------------
Reporter: cohosh | Owner: cohosh
Type: enhancement | Status:
| merge_ready
Priority: High | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: snowflake, design, ex-sponsor-19, | Actual Points: 2
anti-censorship-roadmap |
Parent ID: | Points: 5
Reviewer: | Sponsor:
| Sponsor28-must
-------------------------------------------------+-------------------------
Changes (by phw):
* status: needs_review => merge_ready
Comment:
Replying to [comment:25 cohosh]:
> Thanks! I addressed the feedback above.
>
> I also added the necessary changes for the browser-based proxies and
updated those tests accordingly:
https://github.com/cohosh/snowflake/pull/8
>
> Lowercase vs. uppercase doesn't really bother me. I just left it with
uppercase JSON keys for now.
[[br]]
Looks good to me. I only have a nitpick related to
[https://github.com/cohosh/snowflake/pull/8/commits/5e1fab61ed7cf5279a915714dddde92335bc6b31
5e1fab6]: Do we want constants like `STATUS_CLIENT_MATCH` instead of
string literals like `"client match"`? I could see constants being easier
to maintain but I don't know if this is idiomatic to JavaScript. I'll
leave this up to you to decide.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29207#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs