[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32213 [Core Tor/Tor]: Phase 1: Disable minimal dirauth and relay options when those modules are disabled
#32213: Phase 1: Disable minimal dirauth and relay options when those modules are
disabled
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-design, network-team-roadmap- | Actual Points: 3.3
october |
Parent ID: #31851 | Points: 0.5
Reviewer: nickm | Sponsor:
| Sponsor31-must
-------------------------------------------------+-------------------------
Comment (by teor):
I have deleted the code that conflicts with #32339 and #32344, those
changes are much better.
I disabled the server transport options when the relay module is disabled,
and did some minor cleanup on the relay config code.
Here are my proposed renames, but I won't do them until I've finished the
tests:
{{{
scripts/maint/rename_c_identifier.py --commit \
get_dirportfrontpage relay_get_dirportfrontpage \
parse_port_config port_parse_config \
count_real_listeners port_count_real_listeners \
parse_transport_line pt_parse_transport_line \
ensure_bandwidth_cap config_ensure_bandwidth_cap \
get_effective_bwrate relay_get_effective_bwrate \
get_effective_bwburst relay_get_effective_bwburst \
warn_nonlocal_ext_orports port_warn_nonlocal_ext_orports \
parse_ports_relay port_parse_ports_relay \
update_port_set_relay port_update_port_set_relay \
get_transport_bindaddr_from_config pt_get_bindaddr_from_config \
get_options_for_server_transport pt_get_options_for_server_transport
}}}
TODO:
* improve test coverage, if reasonable
* changes file
* rename new global functions so they are tied to a module/type
* autoformat
* regenerate practracker, but only commit the changes that tighten
restrictions
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32213#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs