[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32342 [Applications/Tor Browser]: Tor Browser for Android crashes when opening the locale pane in the settings

#32342: Tor Browser for Android crashes when opening the locale pane in the
settings
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-mobile, tbb-crash,               |  Actual Points:
  tbb-9.0-issues, tbb-regression,                |
  tbb-9.0.1-can, TorBrowserTeam201910            |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:5 sisbell]:
 > We've seen the omni.ja problem before. The original approach was to just
 delete and add what we didn't need or needed respectively to the final
 apk. This meant, we weren't unzipping and zipping the apk. With the
 ApkTool approach for reproducibility, it's repackaging without the correct
 compression. So I suspect its a problem there.

 It seems this is due to unzipping and then zipping the entire archive.
 `zip` decides if a file should be `stored` or deflated automatically. The
 man page says
 {{{
 zip automatically chooses the better of the two (deflation or store or, if
        bzip2 is selected, bzip2 or store) for each file to be compressed.
 }}}

 We can ignore the `bzip2` part of that.

 One terribly hacky solution is using the current patch, but then deleting
 `assets/omni.ja` from the apk and then re-adding it using `zip -Z store
 assets/omni.ja`, effectively forcing zip not deflating omni.ja. I don't
 remember the details of #31564 well enough right now to remember if there
 is a better alternative right now.

 I worry there are other bugs lurking as a result of our unzip/zip, but I
 don't have a better solution right now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32342#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs