[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1899 [Tor Relay]: We should launch a reachability test immediately if a router changes IP or port

#1899: We should launch a reachability test immediately if a router changes IP or
port
-----------------------+----------------------------------------------------
 Reporter:  nickm      |       Owner:  arma              
     Type:  defect     |      Status:  needs_review      
 Priority:  normal     |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Relay  |     Version:                    
 Keywords:  easy       |      Parent:                    
-----------------------+----------------------------------------------------

Comment(by arma):

 Looks good. My only suggestion is to note that the same logic happens in
 router_add_to_routerlist():

 {{{
       if (router->addr == old_router->addr &&
           router->or_port == old_router->or_port) {
         /* these carry over when the address and orport are unchanged. */
         router->last_reachable = old_router->last_reachable;
         router->testing_since = old_router->testing_since;
       }
 }}}

 and it might be smart to make the logic a function called from each place.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1899#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs