[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #1184 [Tor Client]: Sending useless relay cells after the destroy cell
#1184: Sending useless relay cells after the destroy cell
--------------------------------+-------------------------------------------
Reporter: arma | Type: defect
Status: needs_review | Priority: minor
Milestone: Tor: 0.2.2.x-final | Component: Tor Client
Version: 0.2.2.6-alpha | Resolution: None
Keywords: | Parent:
--------------------------------+-------------------------------------------
Comment(by arma):
Replying to [comment:15 nickm]:
> > "where the heck do we move cells from the circ cell queue onto the
outbuf other than connection_or_flush_from_first_active_circuit() which
seems to only move one cell and then stop"
>
> That's the only place [source: grepping for uses of cell_queue_pop,
which is the only place that pulls a cell of a cell queue]. The function
doesn't "only move one cell and then stop", though. The "for (n_flushed =
0; n_flushed < max && queue->head; ) {" loop in the middle sends more than
one cell. It stops when "max" cells have been flushed to the or_conn's
outbuf, or when there are no more active circuits (that is, ones with
cells to flush).
But max is always 1.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1184#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs