[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #1511 [Tor Relay]: Accounting Resets when System Timezone Changes
#1511: Accounting Resets when System Timezone Changes
-----------------------+----------------------------------------------------
Reporter: BarkerJr | Owner: nickm
Type: defect | Status: needs_review
Priority: major | Milestone: Tor: 0.2.2.x-final
Component: Tor Relay | Version: Tor: 0.2.2.13-alpha
Keywords: | Parent:
-----------------------+----------------------------------------------------
Comment(by arma):
Looks fine to me. Green light to merge when you like.
(That being said, I hate time comparison calculations. :)
I will probably revise this to a 'major bugfix' when I'm making the
changelog, on the assumption that this really is a bug that happens when a
machine moves into or out of daylight saving time. If that's true, we
should probably merge this into 0.2.1.x and then on to master. It's a
serious bug.
All of that said, one question: you say "if it changes by up to 50% either
way", but then your comment says "The start of the period is now a little
later than we remembered." If the period has shifted forward, isn't the
old time now in the previous interval, meaning
{{{
start_of_accounting_period_containing(interval_start_time)
}}}
would be like a month earlier?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1511#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs