[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1362 [Tor Client]: log does not record at NOTICE level when Tor is really ready

#1362: log does not record at NOTICE level when Tor is really ready
----------------------------+-----------------------------------------------
 Reporter:  keb             |         Type:  defect    
   Status:  new             |     Priority:  trivial   
Milestone:                  |    Component:  Tor Client
  Version:  0.2.2.10-alpha  |   Resolution:  None      
 Keywords:                  |       Parent:            
----------------------------+-----------------------------------------------

Comment(by arma):

 In any case, the "we got a netinfo cell from our first hop" message is
 totally not the sign that Tor is ready for application-level connections.
 Notice how right after that line in the code is:
 {{{
     log(LOG_NOTICE, LD_DIR,
         "We now have enough directory information to build circuits.");
     control_event_client_status(LOG_NOTICE, "ENOUGH_DIR_INFO");
     control_event_bootstrap(BOOTSTRAP_STATUS_CONN_OR, 0);
 }}}
 BOOTSTRAP_STATUS_CONN_OR corresponds to the 80% mark in bootstrapping. You
 really want
 {{{
         log_notice(LD_GENERAL,
             "Tor has successfully opened a circuit. "
             "Looks like client functionality is working.");
             control_event_bootstrap(BOOTSTRAP_STATUS_DONE, 0);
 }}}

 So the new question is: when we run out of directory information such that
 we call
 {{{
   if (!res && have_min_dir_info) {
     int quiet = directory_too_idle_to_fetch_descriptors(options, now);
     log(quiet ? LOG_INFO : LOG_NOTICE, LD_DIR,
         "Our directory information is no longer up-to-date "
         "enough to build circuits: %s", dir_info_status);
     control_event_client_status(LOG_NOTICE, "NOT_ENOUGH_DIR_INFO");
   }
 }}}
 should we also set has_completed_circuit to 0, so it will do the "Tor has
 successfully opened a circuit" log line when it next makes a circuit? I
 think the answer is yes.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1362#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs