[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #4065 [Vidalia]: Vidalia: No return in nonvoid function
#4065: Vidalia: No return in nonvoid function
-----------------------+----------------------------------------------------
Reporter: dmacvicar | Owner: chiiph
Type: defect | Status: new
Priority: normal | Milestone:
Component: Vidalia | Version: Vidalia: 0.2.12
Keywords: | Parent:
Points: | Actualpoints:
-----------------------+----------------------------------------------------
Our build service static analyzer detects this error on
ControlMethod.
Simple patch attached. A better fix would be to have a "Unknown" enum
member to support failed string conversions. This would require support in
the code. The current patch just uses ControlMethod::Port in one case and
everything else is ControlMethod::Socket.
(I could not find Vidalia 0.2.14 in the version list)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4065>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs