[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4063 [Tor Client]: Tor 0.2.2 CBT notices are confusing users

#4063: Tor 0.2.2 CBT notices are confusing users
---------------------------+------------------------------------------------
    Reporter:  arma        |       Owner:  StrangeCharm      
        Type:  defect      |      Status:  closed            
    Priority:  normal      |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Client  |     Version:                    
  Resolution:  fixed       |    Keywords:                    
      Parent:              |      Points:                    
Actualpoints:              |  
---------------------------+------------------------------------------------
Changes (by nickm):

  * status:  needs_review => closed
  * resolution:  => fixed


Comment:

 Looks good to me!

 Two cosmetic things I'll fix up:

 First, the issue is in maint-0.2, but you based your ticket-4063 branch on
 the master branch which means that I can't merge your branch onto the
 maint-0.2.2 branch without accidentally pulling in the whole of master.
 Fortunately, it's just one commit, and "git cherry-pick" makes it easy to
 backport those.

 Second, by convention we make a new file in the 'changes' directory for
 everything that will require a changelog entry in the next release.  I'll
 add one here.


 Thanks again!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4063#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs