[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6677 [Compass]: add a 'total' line at the bottom of the table
#6677: add a 'total' line at the bottom of the table
-------------------------+--------------------------------------------------
Reporter: cypherpunks | Owner:
Type: enhancement | Status: needs_revision
Priority: normal | Milestone:
Component: Compass | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Changes (by karsten):
* status: needs_review => needs_revision
Comment:
Replying to [comment:6 gsathya]:
> Replying to [comment:5 karsten]:
> > Looks good, except that "(18 othe" and "(total i" in the fingerprint
column are cut off.
> Damn! I thought I fixed this. Sorry! Please fixup
[https://github.com/gsathya/compass/commit/c90add11b0413d3af95cbe1319f40a95068e56d0
c90add1] when you merge. Thanks!
Hmm, no, that didn't fix the issue for me. I wonder why. Also, maybe you
could rebase to current master? I'm afraid I'll break something when
doing that.
Oh, and I just found that "(total i" is a link to Atlas, which doesn't
really make sense. Can you take that out, too?
> > Also, I wonder if there are any design guidelines for table footers.
Simply adding two more rows works, but there must be prettier ways. How
do other sites format table footers containing summaries?
>
> Googling turned up with this - https://forrst-
production.s3.amazonaws.com/posts/snaps/136973/original.png?1332675932
> It looks pretty, but I have no idea how to implement the CSS. I'll try
playing around with it a bit.
Looks good.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6677#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs