Re: [tor-bugs] #9249 [Tor]: GSOC seccomp stage 2

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#9249: GSOC seccomp stage 2
-----------------------------+--------------------------------------------
     Reporter:  ctoader      |      Owner:  nickm
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-relay gsoc seccomp sandbox
Actual Points:               |  Parent ID:  #5756
       Points:               |
-----------------------------+--------------------------------------------

Comment (by nickm):

 QUick review:
   * In prot_strings, you say: "strlen((char*) el->param)".  Why the cast?
 If we don't know it's a char*, we shouldn't be taking strlen() of it.
 (Are some of these an intptr? The type seems to be an intptr_t ... how do
 we know which ones are strings?)
   * In prot_strings, string lengths should really be size_t.
   * Use tor_malloc() and tor_free() instead of malloc and free.
   * Use tor_strdup(), not strdup().
   * Every function should have documentation.
   * The hints argument to getaddrinfo is "const struct addrinfo hints *",
 not "struct addrinfo hints".  Shouldn't sandbox_getaddrinfo look the same
 way?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9249#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs