Re: [tor-bugs] #8614 [BridgeDB]: BridgeDB should be able to return multiple transport types at the same time

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#8614: BridgeDB should be able to return multiple transport types at the same time
--------------------------+--------------------------
     Reporter:  asn       |      Owner:
         Type:  defect    |     Status:  needs_review
     Priority:  normal    |  Milestone:
    Component:  BridgeDB  |    Version:
   Resolution:            |   Keywords:  important
Actual Points:            |  Parent ID:  #8615
       Points:            |
--------------------------+--------------------------

Comment (by asn):

 Partial review of `bug8614_5_rebased_r4` follows. Haven't seen
 `bug8614_5_rebased_r7` yet.

 * `0e91c34375804e0f42ece1b89f26f0db7c1405d4` seems a bit messy. Why would
 `transports` be True? Isn't it supposed to be a `pluggable transport
 method name` (string?)?

 * Thanks for the extra docs! Here are two places where I would appreciate
 some more docs:
 - I think that there should be some docs on the body of
 `getBridgesForIP()` giving an overview of the algorithm used. That
 function is pretty important but long, borderline messy (at least there
 are tests) and its logic is not apparent.
 - Would be nice to have an example of what we are trying to parse in the
 docstring of `findORAddrSubstringInBridgeLine()`.  Also, what's up with
 the `v` variable? Is it like a `debug` variable? Why not just use
 `logging.debug()` or the bridgedb equivalent?
 - `if` clauses in `testDistWithFilterTransport()` seem to be the same.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8614#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs