[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8510 [Tor]: Add useful Hidden Service related events to the Tor control port

#8510: Add useful Hidden Service related events to the Tor control port
-------------------------+----------------------------------------------
     Reporter:  hellais  |      Owner:
         Type:  task     |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: unspecified
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-hs controller needs-proposal
Actual Points:           |  Parent ID:  #8993
       Points:           |
-------------------------+----------------------------------------------

Comment (by dave2008):

 Hi asn,

 Thanks for your review!

 I am still not sure how to handle the unknown directory, should I change
 the spec to indicate it might return "Unknown directory"? Or should I
 return something else here? If so, generally what should I return for an
 unknown LongName?

 Yep, I think calling assert on hs_dir_node makes more sense. I need to
 look more into it though ;p

 As for tests, no problem, I will look into that as well.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8510#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs